Add clippy to the tools list#1461
Conversation
yaahc
force-pushed
the
rustup-clippy-driver
branch
from
5a18744 to
10f4a78
Compare
src/rustup-cli/self_update.rs
Outdated
|
|
||
| static TOOLS: &'static [&'static str] = | ||
| &["rustc", "rustdoc", "cargo", "rust-lldb", "rust-gdb", "rls"]; | ||
| &["rustc", "rustdoc", "cargo", "rust-lldb", "rust-gdb", "rls", "clippy-driver", "cargo-clippy"]; |
There was a problem hiding this comment.
So if I remember the discussion on discord correctly, we don't actually need clippy-driver here, right?
src/rustup-win-installer/src/lib.rs
Outdated
| "rls", | ||
| "rustfmt", | ||
| "cargo-fmt", | ||
| "clippy-driver", |
yaahc
force-pushed
the
rustup-clippy-driver
branch
from
10f4a78 to
7e1bac0
Compare
|
forgot to push before leaving for the weekend. Should be good now |
yaahc
force-pushed
the
rustup-clippy-driver
branch
from
7e1bac0 to
7553501
Compare
|
Thanks! Can this also update |
|
@alexcrichton While that made sense for rustfmt (because there was stable rustfmt), for clippy it doesn't make much sense. If you turn on the component, your manually installed clippy was probably already broken and will never work again. I think we should just silently overwrite an existing installation |
|
Ah yes, an excellent point! |
|
For those following along, this is now published as rustup 1.13.0 and should be good to go! |
4 participants
Implements rust-lang/rust-clippy#2901